DRAFT: attempt to fix hang on voices for espeak in test #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nb that assertion on length is the expected number of voices. Im nervous about that - maybe it should just be
|
cclauss
reviewed
Nov 14, 2024
cclauss
reviewed
Nov 14, 2024
cclauss
reviewed
Nov 14, 2024
| names = [] | ||
| for _voice in english_voices: | ||
| engine.setProperty("voice", _voice.id) | ||
| # English (America, New York City) --> America, New York City |
There was a problem hiding this comment.
This is much better documentation of what the code does than ~ Extract hame for display.
cclauss
reviewed
Nov 14, 2024
Comment on lines
-76
to
-77
| engine.runAndWait() | ||
| engine.setProperty("voice", voice) # Reset voice to original value |
There was a problem hiding this comment.
Listen to the tests that come after this one to see why restoring defaults makes things sound more intuitive.
Perhaps we need a test that is.
- Start engine.
- Change voice.
- Stop engine.
- Start engine.
- Test if the voice is the default voice or the changed voice.
kip the test if no other voices are available. Use a loop to select a different voice, ensuring a valid change.. Add debug
needed for windows
willwade
changed the title
|
NB: IT seems we have a problem in espeak set voice.. |
|
? We need to get the Windows tests passing soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cclauss take a look - i think this fixes this hang on windows.. but maybe ive refactored too much