feat: SparkLikeNamespace methods
#1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Jan 10, 2025
tests/utils.py
Outdated
Comment on lines
68
to
70
| sorted_indices = sorted( | ||
| range(len(sort_list)), key=lambda i: (sort_list[i] is None, sort_list[i]) | ||
| ) |
There was a problem hiding this comment.
Otherwise list with Nones would just fail to sort
FBruzzesi
commented
Jan 10, 2025
| from pyspark.sql.types import IntegerType | ||
|
|
||
| def _n_unique(_input: Column) -> Column: | ||
| return F.count_distinct(_input) + F.max(F.isnull(_input).cast(IntegerType())) |
There was a problem hiding this comment.
Highly inspired by duckdb implementation 😂😉
FBruzzesi
commented
Jan 10, 2025
| expr._function_name, expr._function_name | ||
| ) | ||
| agg_func = get_spark_function(function_name, **expr._kwargs) | ||
| agg_func = get_spark_function(expr._function_name, **expr._kwargs) |
There was a problem hiding this comment.
I could not manage to make nw.len() work in the group_by context
|
@MarcoGorelli scikit-lego issue is definitly unrelated |
MarcoGorelli
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below
Introduces:
Expr.is_nullExpr.n_uniqueNamespace.lenNamespace.any_horizontalNamespace.mean_horizontalNamespace.min_horizontalNamespace.max_horizontalNamespace.concatNamespace.concat_str