Increase support for SpatialTapGesture #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -260,7 +260,7 @@ internal extension InspectableView { | |||
| return (modifier, []) | |||
| case .composed: | |||
| return traverseComposedGesture(modifier, name, &modifiers) | |||
| case .state : | |||
| case .state: | |||
There was a problem hiding this comment.
fixed swiftlint warning
| @@ -78,7 +78,7 @@ final class GridTests: XCTestCase { | |||
| func testGridRowAlignmentInspection() throws { | |||
| guard #available(iOS 16.0, macOS 13.0, tvOS 16.0, watchOS 9.0, *) | |||
| else { throw XCTSkip() } | |||
| let view = Grid() { GridRow(alignment: .bottom) { EmptyView() } } | |||
| let view = Grid { GridRow(alignment: .bottom) { EmptyView() } } | |||
There was a problem hiding this comment.
fixed swiftlint warning
|
|
||
| @available(iOS 16.0, macOS 13.0, watchOS 9.0, *) | ||
| @available(tvOS, unavailable) | ||
| final class SpatialTapGestureTests: XCTestCase { |
There was a problem hiding this comment.
These were largely pilfered from RotationGestureTests. I'm not sure I understand the full scope of CommonGestureTests, but I hope this covers all intended uses of SpatialTapGesture.
travischapman
approved these changes
Nov 20, 2023
nalexn
added
the
pending release
|
Thank you for this nice addition, @andy-vanwagoner-jn ! |
nalexn
removed
the
pending release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To write tests using
SpatialTapGesture, we needed a way to initialize theValue. This adds the appropriateinit& adds tests forSpatialTapGesture.