Crash: ViewHosting.swift:162: Fatal error: Unexpectedly found nil while unwrapping an Optional value

[esemusa]

Description of the Issue

The crash occurs because ViewInspector's precondition is not safeguarded against external manipulation during testing. Once the static window is initialized and set as the keyWindow, it becomes accessible to other tests, leading to potential crashes.

ViewInspector/Sources/ViewInspector/ViewHosting.swift

Lines 136 to 145 in 21a2ff9

	static func makeWindow() -> UIWindow {
	#if os(visionOS)
	let frame = CGRect(x: 0, y: 0, width: 1280, height: 720)
	#else
	let frame = UIScreen.main.bounds
	#endif
	let window = UIWindow(frame: frame)
	window.rootViewController = UIViewController()
	window.rootViewController?.view.translatesAutoresizingMaskIntoConstraints = false
	window.makeKeyAndVisible()

The crash itself will be triggered here:

ViewInspector/Sources/ViewInspector/ViewHosting.swift

Lines 161 to 163 in 21a2ff9

	static var rootViewController: UIViewController {
	window.rootViewController!
	}

Steps to Reproduce

The following example demonstrates how to reproduce the crash (tested in Xcode 15.4, Simulator iOS 17.5):

import SwiftUI
import ViewInspector
import XCTest

final class ViewInspectorCrash: XCTestCase {
    func testViewInspectorCrash() {
        let view = Text("Crash")

        // This triggers the one-time creation of ViewHosting.window
        ViewHosting.host(view: view)

        // The created window is now the keyWindow and can be accessed and manipulated by any other test
        UIApplication.shared.keyWindow?.rootViewController = nil

        // Manipulation from another test will lead to a crash:
        ViewHosting.host(view: view)
    }
}

Each test execution should be isolated and safe from external interference (ensuring the static window/window.rootViewController is reset or properly cleaned or implementing checks to verify the integrity of the keyWindow before it is used).

[nalexn]

Thanks for the heads up

[nalexn]

Released with v0.10.0