Expose columnar to execute_with_progress #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now there is no way to set columnar in execute_with_progress. It seems all it was missing was to expose the parameter.
|
Great. Can you make a simple test to ensure this wouldn't break in the future? See this test case for example: https://github.com/mymarilyn/clickhouse-driver/blob/27edae4f8e1ec8526e2859fdc6336526eb3c59ee/tests/test_blocks.py |
|
@xzkostyan Added a test |
|
It seems the test is passing. https://travis-ci.org/mymarilyn/clickhouse-driver/jobs/589384652#L789 |
|
flake8 check fails: https://travis-ci.org/mymarilyn/clickhouse-driver/jobs/589384652#L546 |
Add test_select_with_columar_with_column_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now there is no way to set columnar in execute_with_progress. It seems all it was missing was to expose the parameter.