Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle dot in the username #161

Merged
merged 1 commit into from
Feb 19, 2020
Merged

Handle dot in the username #161

merged 1 commit into from
Feb 19, 2020

Conversation

sasanrose
Copy link
Contributor

If you have dots in your username, for instance sasan.rose, stack name generated by UserAccountScopedStackName will result in validation errors:

ValidationError: 1 validation error detected: Value 'MyHelloWorldStack-sasan.rose' at 'stackName' failed to satisfy constraint: Member must satisfy regular expression pattern: [a-zA-Z][-a-zA-Z0-9]*|arn:[-a-zA-Z0-9:/._+]*

@sasanrose sasanrose requested a review from mweagle February 19, 2020 01:11
@mweagle
Copy link
Owner

mweagle commented Feb 19, 2020

lgtm - Thanks @sasanrose

@mweagle mweagle merged commit 8af23a9 into mweagle:master Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants