Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cross-staff arpeggio in chord shape #26002

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

XiaoMigros
Copy link
Contributor

Resolves: #25995

  • I signed the CLA
  • The title of the PR describes the problem it addresses
  • Each commit's message describes its purpose and effects, and references the issue it resolves
  • If changes are extensive, there is a sequence of easily reviewable commits
  • The code in the PR follows the coding rules
  • There are no unnecessary changes
  • The code compiles and runs on my machine, preferably after each commit individually
  • I created a unit test or vtest to verify the changes I made (if applicable)

@oktophonie oktophonie requested a review from miiizen January 7, 2025 14:14
miiizen
miiizen previously approved these changes Jan 7, 2025
@miiizen miiizen dismissed their stale review January 7, 2025 15:16

Forgot to check the vtests!

@miiizen
Copy link
Contributor

miiizen commented Jan 7, 2025

Adding the arpeggio to the skyline creates unwanted space between the staves, as can be seen in the vtests. If we add the arpeggio to the skyline, we need to make sure it isn't taken into account in stave spacing calculations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arpeggio/Clef Collision
2 participants