Implement partial slurs #25883
Merged
Implement partial slurs #25883
+634
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miiizen
force-pushed
the
partial-slurs
branch
2 times, most recently
from
9944367 to
bbd42e1
Compare
oktophonie
approved these changes
Jan 8, 2025
mike-spa
approved these changes
Jan 9, 2025
| @@ -181,7 +181,7 @@ class MeasureBase : public EngravingItem | |||
| int index() const; | |||
| int measureIndex() const; | |||
|
|
|||
| bool isBefore(const MeasureBase* other) const; | |||
| bool isBefore(const EngravingItem* other) const override; | |||
There was a problem hiding this comment.
Personally, I would find it more elegant to keep two separate functions:
bool isBefore(const EngravingItem* other) const override;
bool isBefore(const MeasureBase* other) const;
And if other->isMeasureBase() then the first calls the latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #25426
Depends on: #25745
This PR implements partial slurs. Partial slurs are created by first adding a regular slur, then using the shortcut Alt-Shift-left/right to move the selected endpoint to the next barline in that direction. Partial slurs can only be applied where there are appropriate repeat markings.
To add a partial slur to a single chord, select a note from the chord and the preceding/following barline. Add a tie by using the toolbar button or pressing 's'.
Screen.Recording.2024-12-18.at.17.24.07.mov