[material-ui][Autocomplete] Fix renderOption props type #42689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiegoAndai
added
typescript
package: material-ui
Netlify deploy previewhttps://deploy-preview-42689--material-ui.netlify.app/ Bundle size report |
|
@aarongarciah I've added the "React 19 support" label so we can add it to all PRs related to React 19, in case we need to backport it from v6 (next) to v5 (master). I also added the needs cherry-picking label as this is an issue currently affecting users: #39833 (comment) |
|
Also, I didn't find any other similar type bugs in other components 👍🏼 |
| @@ -361,6 +361,10 @@ export interface UseAutocompleteRenderedOption<Value> { | |||
| index: number; | |||
| } | |||
|
|
|||
| export type UseAutocompleteGetOptionPropsReturnValue = React.HTMLAttributes<HTMLLIElement> & { | |||
| key: any; | |||
There was a problem hiding this comment.
Should we use the type coming from @types/react?
Suggested change
| key: any; | |
| key: React.Key; |
There was a problem hiding this comment.
Ideally, yes, but I would keep any as that's the type declared in Base's getOptionProps and we don't want to update that.
aarongarciah
approved these changes
Jun 19, 2024
aarongarciah
approved these changes
Jun 21, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #39833
Fixes second bug described in #39833 (comment). The first bug was fixed in #42099.
Use the correct type for
renderOptions'spropscallback argument. The type comes from UseAutocompleteReturnValue.Before: https://codesandbox.io/p/sandbox/39833-render-option-type-next-vd4jpp?file=%2Fsrc%2FDemo.tsx
After: https://codesandbox.io/p/devbox/f27pj7?file=%2Fsrc%2FDemo.tsx%3A7%2C18