Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Fix codecov failing on merge commits #13654

Merged

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Nov 20, 2018

Since codecov/codecov-bash#134 has been unanswered and this happened 3 times now I guess it's time to explicitly set the commit SHA. As I see it this should be the default behavior anyway.

@eps1lon eps1lon added the test label Nov 20, 2018
@oliviertassinari oliviertassinari changed the title [ci] Fix codecov failing on merge commits [test] Fix codecov failing on merge commits Nov 20, 2018
@oliviertassinari oliviertassinari merged commit 0e7b22b into mui:master Nov 20, 2018
@oliviertassinari
Copy link
Member

@eps1lon 👌

@eps1lon eps1lon deleted the ci/fix-codecov-fail-on-merge-commit branch November 21, 2018 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants