Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: Add pkgconfig static flag for static library #11689

Merged
merged 1 commit into from
May 20, 2022
Merged

ffmpeg: Add pkgconfig static flag for static library #11689

merged 1 commit into from
May 20, 2022

Conversation

Biswa96
Copy link
Member

@Biswa96 Biswa96 commented May 19, 2022

Fixes #11514
Fixes #11515
Fixes #11538
Fixes #11539

Also remove celt library which is not in development and provided by opus.
@Biswa96
Copy link
Member Author

Biswa96 commented May 19, 2022

@msink This does not solve static ffmpeg issues entirely. The dependencies need some changes also. But this fixes all the linked issues. Next time, please try not to create multiple issues for one topic 🙏

@msink
Copy link

msink commented May 20, 2022

Ok, but when creating that issues for each dependency, I assumed they will be closed when "need some changes also" will be done for them individually :)

@Biswa96
Copy link
Member Author

Biswa96 commented May 20, 2022

Would you like to test the package from CI artifacts please? I have tested with your provided tutorial07.c in the main issue. This change seems to solve all the linked issues in my setup.

@msink
Copy link

msink commented May 20, 2022

At least in MINGW64 mode CI artifact fixes all 4 issues above.

@Biswa96 Biswa96 merged commit 38ee70f into msys2:master May 20, 2022
@Biswa96 Biswa96 deleted the ffmpeg-static branch May 20, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants