Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scm/equations #155

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Scm/equations #155

merged 10 commits into from
Jun 24, 2024

Conversation

JorgeLuizFranco
Copy link
Collaborator

Added basic retrieval equations from CausalGraph generated.

For now, the regression is pure OLS, but we can make improvements. Also, we assume the input for retrieving the equations a SimpleDigraph(est_g in the examples) and a DataFrame, and return the variables and the corresponding coefficients ( linear relationships assumption).

@JorgeLuizFranco
Copy link
Collaborator Author

Expect and check if it is a DAG. Get residual of OLS. x = coefficient[1] + scale[1]*randn(). Parameter ::AbstractMatrix use Tables.jl. SCM should also return the DAG.

@mschauer
Copy link
Owner

A couple of todo's:

[ ] include the file in CausalInference.jl
[ ] figure out if you really need DataFrames, and if so, add it to the project
[ ] write a simple test making sure the code runs.

…and inserted a runnable test for them in test/equations.jl
@JorgeLuizFranco
Copy link
Collaborator Author

A couple of todo's:

[ ] include the file in CausalInference.jl [ ] figure out if you really need DataFrames, and if so, add it to the project [ ] write a simple test making sure the code runs.

Done, Moritz

@mschauer
Copy link
Owner

mschauer commented Jun 22, 2024

Ah great, that is taking shape.

1.) Can you uncommit the changes to the yaml files, why is a figure deleted?
2.) Include the test in runtest.jl

@JorgeLuizFranco
Copy link
Collaborator Author

I think everything now is as requested @mschauer

@mschauer mschauer merged commit 408ab81 into mschauer:master Jun 24, 2024
6 checks passed
@JorgeLuizFranco
Copy link
Collaborator Author

Closes #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants