Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Causal Zig-Zag #119

Merged
merged 39 commits into from
Oct 11, 2023
Merged

Causal Zig-Zag #119

merged 39 commits into from
Oct 11, 2023

Conversation

mschauer
Copy link
Owner

@mschauer mschauer commented Oct 6, 2023

No description provided.

mwien and others added 30 commits August 26, 2023 19:27
@mwien
add sampler with mcs speedup
941e032
@mwien
WIP
c0bacbd
@mwien
fix
1dcc4c3
@mwien
minor
4ec9872
@mschauer
Fixes
823a544
@mschauer
Merge branch 'sampler' of https://github.com/mschauer/CausalInference.jl
24c3875 
 into sampler
@mschauer
Add diagnostics (number of traversals, time of moves)
24e8f60
@mwien
add new counting methods
baa1789
@mschauer
Fix empty set issue and compute average number of undirected edges
3e06fd8
@mschauer
Add ne_total
f806796
@mschauer
Make sampler Bayesian
c8bcee4
@mschauer
More testing, seems to work
102ea88
tested number of changed counts
ae8d5ae
sampling seems to work
80e47ca
push fast version of exact2
69224a8
small bug fix
2f88cd4
@mschauer
Allow testing of the score weighted sampler in higher dimensions
0fa6687
work on iterators
2a6eff5
@mwien
work in progress iterators
6e06cc7
refactor
d8f3246
minor cleanup
32f8fb8
@mschauer
Animation
343dac3
@mwien
speedup and test operator functions
575b593
@mwien
speedup operators
b79ed29
@mschauer
WIP
777f87f
@mschauer
Refactor a bit towards extending the package
1fe5c2f
@mschauer
Fix test of operators
bf54e8e
@mschauer
Add docstring
b9b3bab
@mschauer
Performance improvements, actually use memoization
ebf2a03
@mschauer
add helper to make examples
221cbeb
@mschauer
Copy link
Owner Author

mschauer commented Oct 7, 2023

Sporadic test error

Test Summary:        |   Pass   Total  Time
operators randgraphs | 150000  150000  0.6s
nextCPDAG randgraphs: Error During Test at /Users/smoritz/.julia/dev/CausalInference/test/operators.jl:112
  Got exception outside of a @test
  ArgumentError: collection must be non-empty
  Stacktrace:
    [1] SamplerRangeNDL
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/generation.jl:333 [inlined]
    [2] Sampler
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/generation.jl:189 [inlined]
    [3] Sampler
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/generation.jl:418 [inlined]
    [4] Sampler
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/Random.jl:139 [inlined]
    [5] rand
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/Random.jl:255 [inlined]
    [6] rand
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/Random.jl:260 [inlined]
    [7] macro expansion
      @ ~/.julia/dev/CausalInference/test/operators.jl:128 [inlined]
    [8] macro expansion
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
    [9] top-level scope
      @ ~/.julia/dev/CausalInference/test/operators.jl:113
   [10] include(fname::String)
      @ Base.MainInclude ./client.jl:489
   [11] top-level scope
      @ ~/.julia/dev/CausalInference/test/runtests.jl:5
   [12] include(fname::String)
      @ Base.MainInclude ./client.jl:489
   [13] top-level scope
      @ none:6
   [14] eval
      @ Core ./boot.jl:383 [inlined]
   [15] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:291
   [16] _start()
      @ Base ./client.jl:552
Test Summary:        | Pass  Error  Total  Time
nextCPDAG randgraphs |   56      1     57  3.6s
ERROR: LoadError: Some tests did not pass: 56 passed, 0 failed, 1 errored, 0 broken.
in expression starting at /Users/smoritz/.julia/dev/CausalInference/test/operators.jl:112
in expression starting at /Users/smoritz/.julia/dev/CausalInference/test/runtests.jl:5
ERROR: Package CausalInference errored during testing

@mwien
Copy link
Collaborator

mwien commented Oct 9, 2023

Sporadic test error

Test Summary:        |   Pass   Total  Time
operators randgraphs | 150000  150000  0.6s
nextCPDAG randgraphs: Error During Test at /Users/smoritz/.julia/dev/CausalInference/test/operators.jl:112
  Got exception outside of a @test
  ArgumentError: collection must be non-empty
  Stacktrace:
    [1] SamplerRangeNDL
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/generation.jl:333 [inlined]
    [2] Sampler
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/generation.jl:189 [inlined]
    [3] Sampler
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/generation.jl:418 [inlined]
    [4] Sampler
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/Random.jl:139 [inlined]
    [5] rand
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/Random.jl:255 [inlined]
    [6] rand
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Random/src/Random.jl:260 [inlined]
    [7] macro expansion
      @ ~/.julia/dev/CausalInference/test/operators.jl:128 [inlined]
    [8] macro expansion
      @ /Applications/Julia-1.10.app/Contents/Resources/julia/share/julia/stdlib/v1.10/Test/src/Test.jl:1577 [inlined]
    [9] top-level scope
      @ ~/.julia/dev/CausalInference/test/operators.jl:113
   [10] include(fname::String)
      @ Base.MainInclude ./client.jl:489
   [11] top-level scope
      @ ~/.julia/dev/CausalInference/test/runtests.jl:5
   [12] include(fname::String)
      @ Base.MainInclude ./client.jl:489
   [13] top-level scope
      @ none:6
   [14] eval
      @ Core ./boot.jl:383 [inlined]
   [15] exec_options(opts::Base.JLOptions)
      @ Base ./client.jl:291
   [16] _start()
      @ Base ./client.jl:552
Test Summary:        | Pass  Error  Total  Time
nextCPDAG randgraphs |   56      1     57  3.6s
ERROR: LoadError: Some tests did not pass: 56 passed, 0 failed, 1 errored, 0 broken.
in expression starting at /Users/smoritz/.julia/dev/CausalInference/test/operators.jl:112
in expression starting at /Users/smoritz/.julia/dev/CausalInference/test/runtests.jl:5
ERROR: Package CausalInference errored during testing

Should be fixed by 5547c83

@mschauer mschauer merged commit ca258c7 into master Oct 11, 2023
1 of 4 checks passed
@mwien
Copy link
Collaborator

mwien commented Oct 11, 2023

🥳

@mschauer
Copy link
Owner Author

https://github.com/mschauer/CausalInference.jl/blob/master/docs/src/examples/ges_basic_examples.md

@mschauer mschauer deleted the sampler branch February 29, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mschauer @mwien @marcel3243