RenderObject: Fix geometry key for morph targets. #30302
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #30192
Description
RenderObject.getGeometryCacheKey()
must honor morph target attributes. However, a simple structural comparison like with normal buffer attributes isn't sufficient. Since the vertex data are maintained in a texture viaMorphNode
, render objects can only share a common node builder state if morph target data are equal. That is verified with a newid
attribute onBufferAttribute
level.