Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPURenderer: Fix blending opacity in shadows #30081

Merged
merged 4 commits into from
Dec 10, 2024
Merged

WebGPURenderer: Fix blending opacity in shadows #30081

merged 4 commits into from
Dec 10, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Dec 9, 2024

Related issue: #28973

Description

Fix blending opacity in shadows.

Before After
image image

@sunag sunag added this to the r172 milestone Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024 •
edited
Loading

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 339.21
79.01		 339.21
79.01		 +0 B
+0 B
WebGPU 485.99
134.91		 486.02
134.92		 +33 B
+11 B
WebGPU Nodes 485.45
134.81		 485.49
134.82		 +33 B
+9 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 465.1
112.06		 465.1
112.06		 +0 B
+0 B
WebGPU 555.39
150.39		 555.42
150.41		 +33 B
+17 B
WebGPU Nodes 511.24
140.09		 511.27
140.11		 +33 B
+18 B

@sunag sunag marked this pull request as ready for review December 10, 2024 00:42
@sunag sunag merged commit dc34412 into mrdoob:dev Dec 10, 2024
12 checks passed
@sunag sunag deleted the dev-shadow-rev branch December 10, 2024 00:42
@RenaudRohlinger RenaudRohlinger mentioned this pull request Dec 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r172
Development

Successfully merging this pull request may close these issues.
1 participant
@sunag