Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State the encryption algorithms in the README #27

Closed
shadowbq opened this issue Dec 28, 2022 · 2 comments
Closed

State the encryption algorithms in the README #27

shadowbq opened this issue Dec 28, 2022 · 2 comments

Comments

@shadowbq
Copy link

I understand keeping the UI clean, but the encryption even though you didn’t write the algorithm you choose the implementation details. AES and keysize with PKCS padding options should be explained in the README because THESE ARE implementation details important to users.

You’re documenting the html very clearly but I would like to see it outside of the code.
@mprimi
Copy link
Owner

mprimi commented Dec 28, 2022

I agree, the README should explain the encryption scheme.

davidlfox added a commit to davidlfox/portable-secret that referenced this issue Jun 7, 2024
@davidlfox
mprimi#27 state the algo
615b6da
@mprimi mprimi mentioned this issue Jul 21, 2024
Open
@mprimi
Copy link
Owner

mprimi commented Jul 21, 2024 •
edited
Loading

Added a detailed description of encryption & decryption to readme in #39

See https://mprimi.github.io/portable-secret/#cryptography

@mprimi mprimi closed this as completed Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shadowbq @mprimi