DEVPROD-4926 add use_xlarge_distro option to mongo-task-generator #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamXander
approved these changes
Feb 16, 2024
dmoody256
reviewed
Feb 17, 2024
| let build_variant_name = build_variant.name.as_str(); | ||
|
|
||
| if generated_task.use_large_distro() { | ||
| if generated_task.use_xlarge_distro() && xlarge_distro_name.is_some() { |
There was a problem hiding this comment.
what if you specify both large and xlarge distros? Does that work and it looks like xlarge would take precedence?
There was a problem hiding this comment.
Yes, it works fine and xlarge takes precedence which I think is desired behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for https://jira.mongodb.org/browse/BF-29398 we need to increase the distro size of one generated task but currently generated tasks only allow the variant distro or the configured large distro for a variant. This ticket will add a third option so we will not have to increase the distro size for every task unnecessarily.
Here are the server changes that are necessary for this https://github.com/10gen/mongo/pull/19089
use_xlarge_distro acts as use_large_distro for variants that do not have xlarge_distro_name configured.