WizardCreateDevice1: add Ledger Nano S Plus #3903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mj-xmr please review |
|
Version v0.17.3.2 of Monero GUI software still does not support Ledger Nano S Plus |
|
@guofuhua0930 What exactly is not supported? You have to select "Ledger Nano S" in the menu, but otherwise it should work fine. One person on Reddit seems to have it working. This PR here is just for adding a separate menu entry and picture, which is purely cosmetic. |
|
ok, it worked, thanks |
mj-xmr
approved these changes
Apr 30, 2022
jonathancross
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on feedback from Ledger if we are allowed to use this picture as I'm not sure about the license.
Edit: No reply from Ledger. All other pictures had the correct license so I say we can merge this. In the unlikely case they decide against it we can remove it again.