Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Docker build workflow to using the official Docker build actions #140

Merged
merged 3 commits into from
Dec 25, 2020
Merged

Move Docker build workflow to using the official Docker build actions #140

merged 3 commits into from
Dec 25, 2020

Conversation

fpiesche
Copy link
Contributor

Also build for armv6 because why not.

The only notable caveat here is that this setup uses Docker Hub access tokens rather than passwords - though this is likely more secure than keeping your Docker password in a repo secret nonetheless.

Copy link
Owner

@moncho moncho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks a lot!

Please, update the tag value and I will be happy to merge the PR.

.github/workflows/docker.yml Outdated Show resolved Hide resolved
@moncho moncho merged commit 009c6b0 into moncho:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants