-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configurable interval for monitor mode #87
Comments
Hey, Great that you like the tool and thanks for your kind words!! Current refresh rate is half a second, making it configurable is a nice idea, it will be added. The increase in CPU time consumption when running for a long period of time is most likely an indication of dry misusing resources, could you please share some rough numbers? So, how much CPU is used when dry starts in monitor mode vs CPU usage after a few days when it gets huge. Cheers |
By default refresh rate is set to 500 ms, but it can now be changed by the user. refs #87.
Hi, thanks, that will help it think. Started both htop and dry in a horizontally tiled tmux window and let them run for a few hours:
You can see that dry used more than double the cpu time of htop. It's usually using 2% CPU on this particular VM constantly (Ubuntu Server 18.04.1 LTS - 8 Cores/4GB RAM). My guess is that by reducing the amount of refreshes this will reduce the constant CPU usage to about 0-1% and reduce overall CPU time to be even below htop.
I don't know if I agree with this. Isn't CPU time the total time the CPU used for this process from start until now and must go up over a long period of time? This would make sense to me if we would be talking about RAM usage but any process's CPU time will be huge if you let it run long enough (and it actually does something). The only question is how quickly that happens, which depends on how much work is being done. So by being able to set the screen refresh interval manually, anyone should be able to meet his/her prefered CPU usage/time limit, right? Regards, |
StatsChannel now has a refresh channel on which to receive petitions to refresh stats. On message, stats are read from the Docker stats stream and sent on the stats channel of StatsChannel. refs #87
Thanks for the test @Memphizzz!!
I misunderstood your initial comment and thought you were saying that when left running for a while dry average CPU usage was increasing but you were actually talking about total CPU time, which as you said it always increases with time :) Anyway, I agree that reducing the refresh interval might help a bit with the CPU usage. Next release will include this. Cheers |
Awesome, thank you very much! |
Added in v0.9-beta.9. |
Would it be possible to give this a command line parameter as well? For example: dry -m -r 5000 ? |
Also please make it refresh once, after you've entered a value.. |
@Memphizzz Could you please open a new Issue for this? |
Now that this is added, here is a updated performance overview with the refresh interval set to 5000ms.
Very good improvements in terms of both, constant CPU usage and CPU time. Memory consumption unchanged (good). |
Thanks for sharing!! |
Hi,
first of all, thank you very much for dry! It's an amazing piece of software. I especially like the monitor mode.
Would it be possible to add a configurable interval on how quickly the monitor refreshes? Because if you have dry running for a few days, the consumed CPU time (TIME+) is huge, I guess by limiting the refresh rate to lets say every 30 seconds would improve that.
Thanks in advance and keep up the great work!
The text was updated successfully, but these errors were encountered: