Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Display for IsvSvn #316

Closed
wants to merge 3 commits into from

Conversation

samdealy
Copy link
Contributor

@samdealy samdealy commented Apr 4, 2023

Motivation

Future Work

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags
yare 1.0.2 0 89 12 0 ____
static_assertions 1.1.0 0 243 175 0 ____
subtle 2.4.1 0 377 150 3 ____
displaydoc 0.2.3 0 409 65 24 ____
serial_test 2.0.0 0 768 44 0 ____
cargo-emit 0.2.1 0 824 10 0 ____
rand_core 0.6.4 0 829 162 2 ____
tempfile 3.5.0 0 927 110 46 ____
sha2 0.10.6 0 1061 112 204 ____
getrandom 0.2.9 0 1073 141 235 ____
once_cell 1.17.1 0 1101 139 139 ____
bitflags 2.1.0 0 2035 95 0 ____
textwrap 0.16.0 0 2234 77 0 ____
p256 0.13.1 0 2545 22 0 ____
rand 0.8.5 0 5273 63 32 ____
nom 7.1.3 0 10471 33 40 ____
bindgen 0.64.0 0 20421 15 405 CB__
libc 0.2.141 0 97569 16 525 CB__

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #316 (a35689c) into sam/isv-product-id-display (b67ab03) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@                      Coverage Diff                       @@
##           sam/isv-product-id-display     #316      +/-   ##
==============================================================
+ Coverage                       88.10%   88.13%   +0.03%     
==============================================================
  Files                              47       47              
  Lines                            4396     4409      +13     
==============================================================
+ Hits                             3873     3886      +13     
  Misses                            523      523              
Impacted Files Coverage Δ
core/types/src/svn.rs 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@samdealy samdealy force-pushed the sam/isv-product-id-display branch from 0980cfc to 5fa6422 Compare April 7, 2023 19:10
@samdealy samdealy force-pushed the sam/isv-svn-display branch from d3fe104 to 65b96ce Compare April 7, 2023 19:10
@samdealy samdealy mentioned this pull request Apr 10, 2023
9 tasks
@samdealy samdealy linked an issue Apr 10, 2023 that may be closed by this pull request
9 tasks
@samdealy samdealy changed the title Implement Display for IsvSvn Implement Display for svSvn Apr 10, 2023
@samdealy samdealy changed the title Implement Display for svSvn Implement Display for IsvSvn Apr 10, 2023
@samdealy samdealy marked this pull request as ready for review April 10, 2023 21:35
@meowblecoinbot meowblecoinbot requested a review from a team April 10, 2023 21:36
@samdealy samdealy mentioned this pull request Apr 10, 2023
@samdealy samdealy force-pushed the sam/isv-product-id-display branch from 5fa6422 to 00cbeb3 Compare April 11, 2023 18:21
@samdealy samdealy requested a review from awygle as a code owner April 11, 2023 18:21
@samdealy samdealy force-pushed the sam/isv-svn-display branch from 65b96ce to 534c5a0 Compare April 11, 2023 18:21
@samdealy samdealy force-pushed the sam/isv-product-id-display branch from 00cbeb3 to fa1d378 Compare April 11, 2023 18:23
@samdealy samdealy force-pushed the sam/isv-svn-display branch from 534c5a0 to 862006d Compare April 11, 2023 18:24
@samdealy samdealy force-pushed the sam/isv-product-id-display branch from fa1d378 to e8bdd0b Compare April 11, 2023 18:27
@samdealy samdealy force-pushed the sam/isv-svn-display branch from 862006d to eef4341 Compare April 11, 2023 18:27
@samdealy samdealy force-pushed the sam/isv-product-id-display branch from e8bdd0b to f3422c1 Compare April 11, 2023 18:30
@samdealy samdealy force-pushed the sam/isv-svn-display branch from eef4341 to ae24a09 Compare April 11, 2023 18:30
@samdealy samdealy force-pushed the sam/isv-product-id-display branch from f3422c1 to 2fe895e Compare April 11, 2023 18:33
@samdealy samdealy force-pushed the sam/isv-svn-display branch from ae24a09 to 23b923f Compare April 11, 2023 18:33
@samdealy samdealy force-pushed the sam/isv-product-id-display branch from 2fe895e to 4e4a3b5 Compare April 11, 2023 18:35
@samdealy samdealy force-pushed the sam/isv-svn-display branch from 23b923f to 75eccab Compare April 11, 2023 18:35
@samdealy samdealy force-pushed the sam/isv-svn-display branch from 75eccab to f70d0f4 Compare April 11, 2023 18:37
@samdealy samdealy closed this Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S PRs with less than 100 lines of changes
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Display traits on SGX structs
2 participants