Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mc-sgx-panic-log #24

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Add mc-sgx-panic-log #24

merged 1 commit into from
Jan 13, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Dec 16, 2022

Add a panic handler that will log the panic info from an SGX enclave to
the host

Future Work

Remove use of String for the info struct, added a task to #29 for this.

@github-actions github-actions bot added the rust Pull requests that update rust code label Dec 16, 2022
@github-actions github-actions bot added the size/M Medium-sized PRs label Dec 16, 2022
This was referenced Dec 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #24 (01e877c) into trusted-stderr (7d70100) will not change coverage.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           trusted-stderr      #24   +/-   ##
===============================================
  Coverage           87.59%   87.59%           
===============================================
  Files                   4        4           
  Lines                 129      129           
===============================================
  Hits                  113      113           
  Misses                 16       16           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nick-mobilecoin nick-mobilecoin requested a review from a team as a code owner January 5, 2023 15:19
@nick-mobilecoin nick-mobilecoin force-pushed the trusted-stderr branch 2 times, most recently from 2797a56 to 5ee332c Compare January 5, 2023 16:10
@github-actions github-actions bot added the github_actions Pull requests that update github actions label Jan 5, 2023
Copy link
Contributor

@awygle awygle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving conditional on the mc-sgx-io changes getting merged (the stderr_write_all bit at least looks fine to me in that PR, for the record).

Copy link
Contributor

@NotGyro NotGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, simple addition of a new (currently very small) crate

Add a panic handler that will log the panic info from an SGX enclave to
the host
Base automatically changed from trusted-stderr to main January 13, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update github actions rust Pull requests that update rust code size/M Medium-sized PRs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants