-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add empty rust crates for protobufs #4
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
4d54acb
to
f8be67d
Compare
f8be67d
to
8a7ad0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally there would be a different crate for each package. i.e. the crate would be, like, mc-attestation-types-grpcio
or mc-protobufs-attestation-types-grpcio
.
The thinking is: these crates are the place to host type conversions to "business logic" rust types, which means they will need to depend on the foo-types
-style crates, and I'd love to avoid having a huge dependency tree behind using a subset of these protobufs.
Ensuring we're on the same page graph LR
A[mc-attestation-tonic] --> B[mc-attestation-protobuf-types]
C[mc-attestation-grpcio] --> B
B --> D[mc-attestation-types]
|
8a7ad0c
to
b266a96
Compare
Previously the crates were named to contain all future protobuf types and services, now the crates have been named to only support `attestation` with the intent to create dedicated crates for other gRPC communications.
b266a96
to
bc2c553
Compare
The rust crates are interleaved in the protobuf directories. This prevents mirroring the directory structure in another sub-directory
3add27c
to
cb4343d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
No description provided.