Use IsvProductId from mc-sgx-core-types
#3442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Jul 21, 2023
This was referenced Jul 21, 2023
nick-mobilecoin
force-pushed
the
nick/cpu-svn
branch
from
26328d8 to
b32c421
Compare
nick-mobilecoin
force-pushed
the
nick/product-id
branch
from
13a5f80 to
5f2a274
Compare
nick-mobilecoin
force-pushed
the
nick/cpu-svn
branch
from
b32c421 to
e85be66
Compare
nick-mobilecoin
force-pushed
the
nick/product-id
branch
from
5f2a274 to
fd296e0
Compare
eranrund
approved these changes
Jul 24, 2023
This was referenced Jul 24, 2023
Open
nick-mobilecoin
force-pushed
the
nick/cpu-svn
branch
from
e85be66 to
f207439
Compare
nick-mobilecoin
force-pushed
the
nick/product-id
branch
from
fd296e0 to
124f69b
Compare
|
@nick-mobilecoin started a stack merge that includes this pull request via Graphite. |
nick-mobilecoin
force-pushed
the
nick/cpu-svn
branch
from
f207439 to
982933f
Compare
Previously there was a `ProductId` defined in `mc-attest-core`. Now the `IsvProductId` from `mc-sgx-core-types` is used.
|
Graphite rebased this pull request as part of a merge. |
nick-mobilecoin
force-pushed
the
nick/product-id
branch
from
124f69b to
0a3a550
Compare
|
Graphite couldn't merge this PR because it was not satisfying all requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a
ProductIddefined inmc-attest-core. Now theIsvProductIdfrommc-sgx-core-typesis used.