Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TargetInfo from mc-sgx-core-types #3421

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jul 19, 2023

Change to the TargetInfo from mc-sgx-core-types in order to be able
to create a DCAP quote.

@nick-mobilecoin
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions
Copy link

❌ Heads up, I tried building full-service using this branch and it failed.
Build logs can be found by inspecting the github action run Check that repositories submoduling us will still build after this PR / full-service or by clicking here.

@nick-mobilecoin nick-mobilecoin force-pushed the nick/dcap_target_info branch 2 times, most recently from 75351ff to a1c42c3 Compare July 19, 2023 23:14
Change to the  `TargetInfo` from `mc-sgx-core-types` in order to be able
to create a DCAP quote.
@nick-mobilecoin nick-mobilecoin force-pushed the nick/dcap_target_info branch from a1c42c3 to e646c06 Compare July 20, 2023 16:15
@github-actions
Copy link

✅ Good job, full-service was built successfully.
Build logs can be found by inspecting the github action run Check that repositories submoduling us will still build after this PR / full-service or by clicking here.

@nick-mobilecoin nick-mobilecoin marked this pull request as ready for review July 20, 2023 16:38
.github/workflows/dependent-repos.yml Outdated Show resolved Hide resolved
attest/untrusted/src/lib.rs Show resolved Hide resolved
@nick-mobilecoin nick-mobilecoin requested a review from eranrund July 20, 2023 18:34
@nick-mobilecoin nick-mobilecoin mentioned this pull request Jul 20, 2023
23 tasks
@nick-mobilecoin nick-mobilecoin merged commit 4dbbf03 into master Jul 20, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/dcap_target_info branch July 20, 2023 19:30
voloshyn pushed a commit that referenced this pull request Jul 20, 2023
* Use `TargetInfo` from `mc-sgx-core-types`

Change to the  `TargetInfo` from `mc-sgx-core-types` in order to be able
to create a DCAP quote.

* Fix docker image version for dependent-repos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants