Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add verification of SignedTcbInfo to EvidenceVerifier #128

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Add verification of SignedTcbInfo to EvidenceVerifier #128

merged 3 commits into from
Jul 12, 2023

Conversation

nick-mobilecoin
Copy link
Collaborator

@nick-mobilecoin nick-mobilecoin commented Jul 12, 2023 •
edited
Loading

No description provided.

@nick-mobilecoin nick-mobilecoin mentioned this pull request Jul 12, 2023
Merged
@nick-mobilecoin
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@github-actions github-actions bot added the size/L Large PRs label Jul 12, 2023
@meowblecoinbot meowblecoinbot requested a review from a team July 12, 2023 16:46
@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited
Loading

❌ Unreviewed dependencies found

Crate Version Reviews (N/2) LoC Left-Pad Index Geiger Flags
yare 1.0.2 0 89 11 0 ____
mc-sgx-dcap-sys-types 0.7.0 0 124 4 0 CB__
assert_matches 1.5.0 0 209 86 0 ____
mc-sgx-core-sys-types 0.7.0 0 226 5 0 CB__
subtle 2.5.0 0 440 149 9 ____
hex 0.4.3 0 474 147 0 ____
displaydoc 0.2.4 0 600 59 20 ____
x509-cert 0.2.3 0 1963 6 0 ____
textwrap 0.16.0 0 2234 73 0 ____
mc-sgx-core-types 0.7.0 0 2255 1 0 ____
p256 0.13.2 0 2545 25 0 ____
mc-sgx-dcap-types 0.7.0 0 2587 0 12 ____
rand 0.8.5 0 5273 65 32 ____
der 0.7.7 0 7848 24 0 ____
serde 1.0.171 0 10534 49 5 CB__
serde_json 1.0.100 0 12167 42 7 CB__

@codecov
Copy link

codecov bot commented Jul 12, 2023 •
edited
Loading

Codecov Report

Merging #128 (d48fe31) into main (74dfc0c) will decrease coverage by 0.07%.
The diff coverage is 95.42%.

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   98.22%   98.15%   -0.07%     
==========================================
  Files          13       13              
  Lines        3939     4068     +129     
==========================================
+ Hits         3869     3993     +124     
- Misses         70       75       +5
Impacted Files Coverage Δ
verifier/src/certificate_chain.rs 100.00% <ø> (ø)
verifier/src/error.rs 70.00% <ø> (ø)
verifier/src/evidence.rs 95.25% <94.40%> (+0.04%) ⬆️
verifier/src/tcb.rs 98.98% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

nick-mobilecoin
nick-mobilecoin commented Jul 12, 2023
View reviewed changes
verifier/src/tcb.rs Outdated Show resolved Hide resolved
@nick-mobilecoin nick-mobilecoin requested review from eranrund and dolanbernard and removed request for a team July 12, 2023 16:53
eranrund
eranrund reviewed Jul 12, 2023
View reviewed changes
verifier/src/evidence.rs Outdated Show resolved Hide resolved
verifier/src/evidence.rs Show resolved Hide resolved
verifier/src/evidence.rs Outdated Show resolved Hide resolved
verifier/src/evidence.rs Outdated Show resolved Hide resolved
verifier/src/evidence.rs Outdated Show resolved Hide resolved
Base automatically changed from nick/app-verifier to main July 12, 2023 19:03
@nick-mobilecoin
Use an Option<T> instead of Result<T, ()>
5fbe343 
Previously a `Result<T, ()> was used when trying to get the public
signing key out of a certificate. Now an `Option<T>` is used which
improves the ergonomics.

Also moved `SignedTcbInfoVerifier` into the `EvidenceValue` instead of
using interior mutability in the `EvidenceVerifier`.
@nick-mobilecoin nick-mobilecoin requested a review from eranrund July 12, 2023 19:55
@nick-mobilecoin
Change SignedTcbInfoVerifier to use an optional key
d48fe31 
Previously the `SignedTcbInfoVerifier` required a key to verify the TCB
info. Now the `SignedTcbInfoVerifier` takes an `Option<VerifyingKey>`.
This provides a more ergonomic interface when the verifying key cannot
be determined.
eranrund
eranrund approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nick-mobilecoin nick-mobilecoin merged commit af2dc17 into main Jul 12, 2023
@nick-mobilecoin nick-mobilecoin deleted the nick/add-qe-identity branch July 12, 2023 21:01
This was referenced Jul 11, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eranrund eranrund eranrund approved these changes

@dolanbernard dolanbernard Awaiting requested review from dolanbernard

Assignees

@nick-mobilecoin nick-mobilecoin

Labels
size/L Large PRs
Projects
Core PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-mobilecoin @eranrund