- Add plot_time_var argument to autoplot() for 3D plotting
#197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 79.63% 79.46% -0.17%
==========================================
Files 28 28
Lines 2283 2289 +6
==========================================
+ Hits 1818 1819 +1
- Misses 465 470 +5
Continue to review full report at Codecov.
|
pat-s
changed the title
"plot" column role for 3D plottingplot_time_var argument to autoplot() for 3D plotting
pat-s
changed the title
plot_time_var argument to autoplot() for 3D plottingplot_time_var argument to autoplot() for 3D plotting
pat-s
added a commit
that referenced
this pull request
Jun 17, 2022
pat-s
added a commit
that referenced
this pull request
Jun 17, 2022
pat-s
added a commit
that referenced
this pull request
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies to the use case of partitioning by space only but plotting 3D (which requires a time variable).
This PR allows for this via column role
"plot".@be-marc Should be rename the role to
"plot_time"? Otherwise we might eventually get conflicts with other plotting functions elsewhere?I also used a subset of the cookfarm task only for the plotting tests as otherwise the SVG files become too large.