Fix: correctly escape text that would otherwise be interpreted as raw HTML and HTML blocks. #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raw HTML and HTML blocks. Closes mixmark-io#106 Closes mixmark-io#261
|
I need this fixed. It will fix an issue in my projects. |
|
I also just encountered this, would love to see it fixed. @martincizek @pavelhoral any chance you could take a look? |
|
One more upvote for this PR (and a vouch for it—I tested this one locally and in the Current behavior is a bit dangerous as escaped HTML is converted to unescaped HTML in Turndown output. |
zachleat
added a commit
to zachleat/fork-turndown
that referenced
this pull request
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the issues linked below for a good description of the issue. Given readable text in HTML, which renders as
<iframe src="http://www.w3schools.com"></iframe>, the correct Turndown translation is\<iframe src="http://www.w3schools.com">\</iframe>, but the current behavior is<iframe src="http://www.w3schools.com"></iframe>.Closes #106
Closes #261