feat(misskey-js): allow setting binaryType
of WebSocket connection
#15190
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR allows developers who use
misskey-js
to customizebinaryType
of the underlying WebSocket connection when using the streaming API.Why
I wanted to use this library on bun to create a bot application with streaming capability.
However, bun does not support WebSocket connections with
binaryType
set toblob
(probably just yet), which happens to be the default value.See: oven-sh/bun#8721
Additional info (optional)
I'm not very sure if testing this over a mocked WebSocket server (
new WS('wss://misskey.test/streaming')
) would be helpful, as what really matters here is whether the real Misskey servers accept WebSocket connections ofarraybuffer
binary type.As far as I can test, it is working without any issues when connecting to my own Misskey instance.
Checklist