Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

アンテナ、リスト等の名前をdeckのカラム名のデフォルト値にするように #13992

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

anatawa12
Copy link
Member

What

Fixes #11077

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@anatawa12 anatawa12 changed the title アンテナ、リスト等の名前をカラム名のデフォルト値にするように アンテナ、リスト等の名前をdeckのカラム名のデフォルト値にするように Jun 14, 2024
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 17.85714% with 69 lines in your changes missing coverage. Please review.

Project coverage is 20.06%. Comparing base (13439e0) to head (a28ab48).

Files with missing lines Patch % Lines
packages/frontend/src/ui/deck/list-column.vue 0.00% 15 Missing ⚠️
packages/frontend/src/ui/deck/channel-column.vue 0.00% 14 Missing ⚠️
packages/frontend/src/ui/deck/deck-store.ts 0.00% 10 Missing ⚠️
...ages/frontend/src/ui/deck/role-timeline-column.vue 0.00% 10 Missing ⚠️
packages/frontend/src/ui/deck/antenna-column.vue 0.00% 9 Missing ⚠️
packages/frontend/src/ui/deck/column.vue 0.00% 3 Missing ⚠️
packages/frontend/src/ui/deck/direct-column.vue 0.00% 2 Missing ⚠️
packages/frontend/src/ui/deck/mentions-column.vue 0.00% 2 Missing ⚠️
packages/frontend/src/ui/deck.vue 0.00% 1 Missing ⚠️
...ages/frontend/src/ui/deck/notifications-column.vue 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13992       +/-   ##
============================================
- Coverage    40.31%   20.06%   -20.26%     
============================================
  Files         1564      729      -835     
  Lines       198083   104113    -93970     
  Branches      3837     1198     -2639     
============================================
- Hits         79863    20890    -58973     
+ Misses      117617    82671    -34946     
+ Partials       603      552       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor

lintがあかんかも

@anatawa12
Copy link
Member Author

dockleに気を取られて気づいてなかったですありがとうございます

@anatawa12
Copy link
Member Author

直しました(fix on saveが切れてた)

@Sayamame-beans
Copy link
Member

Conflict解消

@kakkokari-gtyih
Copy link
Contributor

kakkokari-gtyih commented Jan 8, 2025

既に名前が指定されている場合でもデフォルト値用の名前取得のためだけにリクエストが発火されるのが無駄かもしれない(もしくはわたしが何か見逃してる…?)

@anatawa12
Copy link
Member Author

既に名前が指定されている場合でもデフォルト値用の名前取得のためだけにリクエストが発火されるのが無駄かもしれない(もしくはわたしが何か見逃してる…?)

たしかにそうですね。nameがnull or emptyのときのみにしたほうが良いですね

@anatawa12
Copy link
Member Author

不要な場合には取得しないようにしました。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
Development

Successfully merging this pull request may close these issues.

Deckのカラム追加時にアンテナ、リスト等の名前をカラムの名前にしてほしい
4 participants