-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
アンテナ、リスト等の名前をdeckのカラム名のデフォルト値にするように #13992
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13992 +/- ##
============================================
- Coverage 40.31% 20.06% -20.26%
============================================
Files 1564 729 -835
Lines 198083 104113 -93970
Branches 3837 1198 -2639
============================================
- Hits 79863 20890 -58973
+ Misses 117617 82671 -34946
+ Partials 603 552 -51 ☔ View full report in Codecov by Sentry. |
lintがあかんかも |
dockleに気を取られて気づいてなかったですありがとうございます |
直しました(fix on saveが切れてた) |
Conflict解消 |
既に名前が指定されている場合でもデフォルト値用の名前取得のためだけにリクエストが発火されるのが無駄かもしれない(もしくはわたしが何か見逃してる…?) |
たしかにそうですね。nameがnull or emptyのときのみにしたほうが良いですね |
不要な場合には取得しないようにしました。 |
What
Fixes #11077
Why
Additional info (optional)
Checklist