Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): 返信が最大30件しか読み込めない問題を修正 #13004

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Jan 15, 2024

What

NoteDetailedの返信の表示をMkPagination(自動読み込みは無効)で制御するようにした

Why

返信が30件以上読み込めない問題を修正
例: https://misskey.io/notes/9oij2d26kd820805

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 15, 2024
Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b0fdfc) 56.85% compared to head (bbd9c63) 77.75%.

❗ Current head bbd9c63 differs from pull request most recent head b4b7f31. Consider uploading reports for the commit b4b7f31 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #13004       +/-   ##
============================================
+ Coverage    56.85%   77.75%   +20.90%     
============================================
  Files          781      181      -600     
  Lines        82196    24081    -58115     
  Branches      3830      433     -3397     
============================================
- Hits         46734    18725    -28009     
+ Misses       35462     5356    -30106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih
Copy link
Contributor Author

上位互換 #13006 ができたのでClose

@kakkokari-gtyih kakkokari-gtyih deleted the fix-notedetail-replylimit branch January 15, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant