add --assume-duration flag to env and shell #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquella
reviewed
Oct 15, 2018
env.go
Outdated
| if err != nil { | ||
| return nil, err | ||
| } | ||
| v.AWSKey.RoleDuration = assumeDuration |
There was a problem hiding this comment.
If there is no AWSKey configured in the vault, this could cause a SEGFAULT. We need to guard this with a v.AWSKey != nil check.
env.go
Outdated
| @@ -150,8 +158,24 @@ func (e *Env) getSession(store vaulted.Store) (*vaulted.Session, error) { | |||
| } | |||
|
|
|||
| if e.Role != "" { | |||
| return session.Assume(e.Role) | |||
| assumeDuration, err := e.getAssumeDuration() | |||
There was a problem hiding this comment.
Delaying the parsing of the duration to this point means that we will have already prompted the user for their vault password and MFA before we throw an error indicating that their duration was ill formatted. We should probably validate the duration format before we open the vault.
add the --assume-duration flag to env and shell commands to allow specifying a custom role duration from the CLI
allows saving an assume role duration inside of the vault that will be used alongside a stored role
ryan-norton
force-pushed
the
assume-duration
branch
from
c5b5fa5 to
682fa60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add the --assume-duration flag to env and shell commands to allow
specifying a custom role duration from the CLI