-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCMSPUI-454: Implement EBS Get Notifications Endpoint on PUI UI #129
Merged
JamieBriggs-MoJ
merged 19 commits into
main
from
store/ccmspui-454_reimplement_get_notifications
Jan 9, 2025
Merged
CCMSPUI-454: Implement EBS Get Notifications Endpoint on PUI UI #129
JamieBriggs-MoJ
merged 19 commits into
main
from
store/ccmspui-454_reimplement_get_notifications
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
…mapping XML values Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
…ntities in NotificationRepository Signed-off-by: Jamie Briggs <[email protected]>
…ntrollerTests Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
# Conflicts: # data-service/src/main/java/uk/gov/laa/ccms/data/repository/specification/NotificationSpecification.java
Signed-off-by: Jamie Briggs <[email protected]>
Signed-off-by: Jamie Briggs <[email protected]>
PhilDigitalJustice
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
farrell-m
approved these changes
Jan 9, 2025
JamieBriggs-MoJ
deleted the
store/ccmspui-454_reimplement_get_notifications
branch
January 9, 2025 10:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of work for CCMSPUI-454, the get notifications screen need to be refactored to utilise the EBS API instead of the SOA API following work done as part of CCMSPUI-453.
Included in the PR is also additional changes to the repository specification to better support the changes made to PUI UI