Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EvaluationResult as rule evaluation result. #5144

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

blkt
Copy link
Contributor

@blkt blkt commented Dec 5, 2024

Summary

Return a structured result from the evaluation engine, as well as an error.

A followup PR will update each of the evaluation engines to return a useful structured result, currently it is left empty for the sake of making the PR easier to review.

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Unit tests were updated according to the change.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

Ref #5120

Co-authored-by: Michelangelo Mori <[email protected]>
@eleftherias eleftherias force-pushed the feat/eval-engine-evaluation-result branch from c39d737 to 8011c29 Compare December 13, 2024 15:55
@coveralls
Copy link

Coverage Status

coverage: 55.364% (+0.007%) from 55.357%
when pulling 8011c29 on feat/eval-engine-evaluation-result
into ee82c4b on main.

@eleftherias eleftherias marked this pull request as ready for review December 16, 2024 08:09
@eleftherias eleftherias requested a review from a team as a code owner December 16, 2024 08:09
@eleftherias eleftherias self-assigned this Dec 16, 2024
@eleftherias eleftherias merged commit d843a45 into main Dec 16, 2024
27 checks passed
@eleftherias eleftherias deleted the feat/eval-engine-evaluation-result branch December 16, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants