Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 3MF component path #2296

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Support 3MF component path #2296

merged 4 commits into from
Oct 14, 2024

Conversation

mikedh
Copy link
Owner

@mikedh mikedh commented Oct 14, 2024

For some reason in a larger 3MF file the memory-free behavior was deadlocking somehow (maybe playing poorly with the events=('end',) somehow?) and turning a 5s load into a repeatably 1000s load. I removed the following block and it went away:

        # free resources
        obj.clear()
        obj.getparent().remove(obj)
        del obj

This also adds support for the <component path="file-path-in-archive ... mechanism which should fix #2294.

@mikedh mikedh merged commit cde81e4 into release/revolve Oct 14, 2024
2 of 9 checks passed
@mikedh mikedh deleted the feat/3mfextra branch October 14, 2024 19:38
@mikedh mikedh mentioned this pull request Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant