Fixed linting local development

[mokshith-moksh]

Linked Issue(s)

Closes #600

Acceptance Criteria fulfillment

• The linter should work locally on respective submodules.
• The linter should run on saving of files (only the currently changed file(s) ideally).
• It should work on respective files regardless of whether I opened the submodule directly or the whole repo.
• It should work at least in VSCode perfectly.

Proposed changes (including videos or screenshots)

Further comments

The solution involved configuring the ESLint settings in both the CLI and web-server submodules to ensure consistent behavior across the repository. I prioritized getting it to work seamlessly in VSCode, as specified in the acceptance criteria. Alternative approaches were considered, but this configuration best meets the project's linting requirements.

[mokshith-moksh]

there was the error at e051571 because of the change in prettier version , I have updated it , now it's perfectly Good.

[jayantbh]

I think your yarn install updated some things here. Try yarn install with --frozen-lockfile

[mokshith-moksh]

I am working on it

[jayantbh]

What exactly changed in this file and why?

[mokshith-moksh]

Hi @jayantbh ,

In the pre-commit.yml file, testing is occurring using the command: yarn add eslint@^8.40.0 [email protected] eslint-plugin-import@^2.29.0 eslint-plugin-prettier@^5.0.1 eslint-plugin-react@^7.29.4 eslint-plugin-unused-imports@^3.0.0 --dev. I thought these packages need to be installed in the cli app to ensure that linting works properly.

[jayantbh]

No no. I mean, you see the whitespace changes right?

[jayantbh]

Checking if you've seen this reply. ☝🏽

[jayantbh]

Changes in this file seem unintentional.

[mokshith-moksh]

Hi @jayantbh,

I added this because the ESLint rule configuration for quotes ensures that the code follows consistent quote usage. The settings are as follows:

• error : This means ESLint will throw an error if the rule is violated.
• single : This enforces the use of single quotes for strings.
• { avoidEscape: true, allowTemplateLiterals: true }`:
  • avoidEscape: true allows the use of double quotes if it helps avoid escaping single quotes, making the code
    more readable.
  • allowTemplateLiterals: true permits the use of template literals (backticks) for strings that require interpolation or multi-line formatting.

This configuration is designed to enforce consistent and readable string formatting throughout the codebase.

[jayantbh]

I was pointing to the abundance of blank lines

[jayantbh]

Which seem to be gone now

[mokshith-moksh]

Hi @jayantbh,

I apologize for the issue. I have fixed all the problems. Could you please go through it now?

[jayantbh]

Hey @mokshith-moksh, I recommend renaming the commits to better reflect that they actually contain.

[jayantbh]

I don't think error should be thrown around like that.

Things that can potentially lead to serious or breaking outcomes should be set to the error level, but otherwise should be set at a warning level.

[mokshith-moksh]

Hi @jayantbh,
I gave changed to warn , the linter will still detect violations (like using double quotes), but instead of failing, it will issue a warning

[jayantbh]

I see that there's a bunch of changes to the configs, but I'd expect for a bunch of code files to also have changed assuming the rules were actually applied and run on them as a result.

Nothing changed?

I mean, it is not impossible given that the linting check passed successfully.

[mokshith-moksh]

Hi @jayantbh,
fixed: change quotes rule from error to warn and applied linting across codebase , now there is couple changes in the codebase as linting is applied to the codebase.

[jayantbh]

@mokshith-moksh I see a lot of previous commits with the same improper naming. Only the most recent one named appropriately. You might need to do an interactive rebase.

[mokshith-moksh]

Hi @jayantbh,

I have performed an interactive rebase and renamed the commits with proper naming.

[jayantbh]

Seems to work for me! Good stuff!