update workflow to spawn arm runner on demand #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wip wip wip wip wip
adnanhashmi09
force-pushed
the
ami-workflow
branch
from
ecd1360 to
f85c0d8
Compare
samad-yar-khan
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue(s)
Acceptance Criteria fulfillment
Proposed changes (including videos or screenshots)
Earlier our docker build for ARM was running in a self hosted ec2 machine which was always running and waiting for jobs. That wasn't very cost effective. So this PR spawns an EC2 machine in our infra using AMI id. It spawns it before building the docker images and then closes the instance when the build is complete.
Further comments