Revert PR sync for gitlab #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samad-yar-khan
requested changes
Jul 3, 2024
| if pr.state != PullRequestState.MERGED: | ||
| continue | ||
|
|
||
| pr_merge_hash_match_strings.append(f"revert-{pr.merge_commit_sha[:8]}") |
There was a problem hiding this comment.
is this pattern for revert pr branch names always true ?
| """ | ||
| revert_pr_hashes: List[str] = [] | ||
| repo_ids: Set[str] = set() | ||
| repo_id_to_pr_merge_hash_to_id_map: Dict[str, Dict[str, str]] = {} |
There was a problem hiding this comment.
repo_id_to_pr_merge_hash_to_revert_pr_id_map would make this more readable as this code is already kind of complex
There was a problem hiding this comment.
Yeah, makes sense. Made the changes. Thanks for the suggestion.
samad-yar-khan
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issue(s)
Closes #460
Proposed Changes
A service module to sync gitlab revert prs. This will be called by the gitlab sync service which will be later implemented. Tests are also written for the same service.