update team repos api to send deployment_type in the response for each repo #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samad-yar-khan
requested changes
Jun 21, 2024
Comment on lines
25
to
27
| def get_team_repos_by_team_id(self, team: Team) -> List[TeamRepos]: | ||
| return self._code_repo_service.get_team_repos_by_team_id(team_id=str(team.id)) | ||
|
|
There was a problem hiding this comment.
get_team_repos_by_team_id we should update the func name as we are fetching the entity by passing the team object and not just the id.
How about get_team_repos_mapping ?
There was a problem hiding this comment.
Yeah makes sense. get_team_repos_mapping is a little misleading since it doesn't really return a map. How about get_team_repos_by_team?
… check since query.all() returns an empty list by default Co-authored-by: Samad Yar Khan <[email protected]>
samad-yar-khan
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
/teams/<team_id>/reposhas been updated to send thedeployment_typein the response for each repo