"Update GitHub integration handling and token validation" #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samad-yar-khan
requested changes
May 6, 2024
web-server/pages/integrations.tsx
Outdated
| @@ -55,7 +55,7 @@ const Content = () => { | |||
| orgId, | |||
| integrations: { github: isGithubIntegrated } | |||
| } = useAuth(); | |||
| const isLinked = useSelector((s) => s.auth.org.integrations.github === true); | |||
| const isLinked = useSelector((s) => s.auth.org?.integrations.github === true); | |||
There was a problem hiding this comment.
this and below code seems a bit repetitive ?
| @@ -21,7 +21,7 @@ const getRadiusWithPadding = (radius: number, padding: number) => | |||
|
|
|||
| export const GithubIntegrationCard = () => { | |||
| const theme = useTheme(); | |||
| const isLinked = useSelector((s) => s.auth.org.integrations.github === true); | |||
| const isLinked = useSelector((s) => s.auth.org?.integrations.github === true); | |||
Comment on lines
+90
to
+94
| // @ts-ignore | ||
| Authorization: `token ${dec(token)}` | ||
| } | ||
| }); | ||
| return response.status === 200; // Check for successful response status code |
There was a problem hiding this comment.
actually it was intentional
samad-yar-khan
requested changes
May 6, 2024
| @@ -37,7 +39,7 @@ export const GithubIntegrationCard = () => { | |||
|
|
|||
| return ( | |||
| <FlexBox relative> | |||
| {isLinked && ( | |||
| {integrations.github && ( | |||
There was a problem hiding this comment.
Suggested change
| {integrations.github && ( | |
| {isGithubIntegrated && ( |
… of integrations.github
samad-yar-khan
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes updates to handle nullable org integrations in the GitHubIntegrationCard, integrations.tsx, and session.ts files. It also adds token validation for GitHub integrations.