Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI workflows to run pytests and black only for changes in the backend directory #224 #233

Merged
merged 1 commit into from
May 2, 2024

Conversation

JuanJoseLL
Copy link
Contributor

@JuanJoseLL JuanJoseLL commented May 2, 2024


Closes #224

This PR addresses issue #224 by updating the GitHub Actions workflows to trigger the Python-centric tests (pytests and black) only when there are changes in the 'backend' directory. Previously, these workflows were running for all pull requests, which could be unnecessary for changes that don't affect the Python code (like updates to the web-server).

This optimization reduces unnecessary CI runs, speeding up development and reducing resource usage. Changes include:

  • Modified .github/workflows/pytest.yml to add path filters.
  • Adjusted .github/workflows/black.yml similarly.

This should streamline the development process for contributors focusing on the TypeScript/Next.js portions of the project by not running Python-specific checks on unrelated PRs.

@CLAassistant
Copy link

CLAassistant commented May 2, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@amoghjalan amoghjalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing @JuanJoseLL, Thanks for the contribution!

@amoghjalan amoghjalan merged commit fff3112 into middlewarehq:main May 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest and black workflows should not run for web-server changes
3 participants