-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add search suggestions for repo-search #445
Comments
Middleware.mp4@e-for-eshaan Does this solve the purpose? I can make it better by adding the slide animations if it does. |
Hey @KartikChawla09
Feel free to ask for any other questions and doubts, or even to discuss the code-approach, we'll be glad to help! |
Thank you very much for the feedback, I have changed the names of the repos to the ones mentioned. Also, I have removed the quotes. Do you have any suggestions regarding how I should go about adding the animations to the text without using additional packages. Update : I was reading the documentation of Material UI (since it is already being used) and came across the |
Well, this is how i did it, hope this helps! https://codesandbox.io/p/sandbox/trying-changing-placeholders-ttxq6z?file=%2Fsrc%2FApp.tsx |
SlideAnimation.mp4@e-for-eshaan can you check this once ? Earlier I was implementing it using the |
Why do we need this ?
it is unclear right now that the repo-search allows passing of org-names.
eg: to search this repo, one can type
middlewarehq/middleware
.Hence it is important to implement a subtle CTA. A place holder of such sort can be used to display some suggestions like:
search HigherOrderCO/Bend
search middlewarehq/middleware
search RocketChat/Rocket.Chat
Screen.Recording.2024-06-21.at.10.06.39.PM.mov
Acceptance Criteria
try not to add any additional packages
theme must be kept similiar to the pre-existing UI
write optimized and efficient code
TODO 1
TODO 2
TODO 3
Further Comments / References
The text was updated successfully, but these errors were encountered: