Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search suggestions for repo-search #445

Closed
3 tasks
e-for-eshaan opened this issue Jun 21, 2024 · 5 comments · Fixed by #459
Closed
3 tasks

Add search suggestions for repo-search #445

e-for-eshaan opened this issue Jun 21, 2024 · 5 comments · Fixed by #459
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code web-server Issue related to web-server

Comments

@e-for-eshaan
Copy link
Contributor

e-for-eshaan commented Jun 21, 2024

Why do we need this ?

it is unclear right now that the repo-search allows passing of org-names.
eg: to search this repo, one can type middlewarehq/middleware.

Hence it is important to implement a subtle CTA. A place holder of such sort can be used to display some suggestions like:

search HigherOrderCO/Bend
search middlewarehq/middleware
search RocketChat/Rocket.Chat

ezgif com-video-to-gif-converter

Screen.Recording.2024-06-21.at.10.06.39.PM.mov

Acceptance Criteria

  • try not to add any additional packages

  • theme must be kept similiar to the pre-existing UI

  • write optimized and efficient code

  • TODO 1

  • TODO 2

  • TODO 3

Further Comments / References

@e-for-eshaan e-for-eshaan added enhancement New feature or request javascript Pull requests that update Javascript code web-server Issue related to web-server good first issue Good for newcomers labels Jun 21, 2024
@KartikChawla09
Copy link
Contributor

Middleware.mp4

@e-for-eshaan Does this solve the purpose? I can make it better by adding the slide animations if it does.

@e-for-eshaan
Copy link
Contributor Author

Middleware.mp4
@e-for-eshaan Does this solve the purpose? I can make it better by adding the slide animations if it does.

Hey @KartikChawla09

  • the transition looks choppy, we need to add some smooth animations
  • use repos which are both popular and have short names [golang/go, mozilla/rust, apple/swift, oven-sh/bun]
  • maybe remove the quotes "tensorflow/tensorflow"

Feel free to ask for any other questions and doubts, or even to discuss the code-approach, we'll be glad to help!

@KartikChawla09
Copy link
Contributor

KartikChawla09 commented Jun 23, 2024

Thank you very much for the feedback, I have changed the names of the repos to the ones mentioned. Also, I have removed the quotes. Do you have any suggestions regarding how I should go about adding the animations to the text without using additional packages.

Update : I was reading the documentation of Material UI (since it is already being used) and came across the Slide component. Maybe it will do the job.

@e-for-eshaan
Copy link
Contributor Author

Well, this is how i did it, hope this helps!

https://codesandbox.io/p/sandbox/trying-changing-placeholders-ttxq6z?file=%2Fsrc%2FApp.tsx

@KartikChawla09
Copy link
Contributor

KartikChawla09 commented Jun 24, 2024

SlideAnimation.mp4

@e-for-eshaan can you check this once ? Earlier I was implementing it using the Slide MUI Component but now I have done it using your approch. If this looks fine I will raise a PR.

Update:
image
Just fixed the empty space in the label as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers javascript Pull requests that update Javascript code web-server Issue related to web-server
Projects
None yet
2 participants