Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle terminal progress #237573

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Handle terminal progress #237573

merged 3 commits into from
Jan 10, 2025
+243 −152

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jan 9, 2025

Fixes #237564

Using setting:

"terminal.integrated.tabs.description": "${task}${separator}${local}${separator}${cwdFolder}${separator}${progress}",

Recording 2025-01-09 at 06 00 57 (1)

@Tyriar Tyriar added this to the January 2025 milestone Jan 9, 2025
@Tyriar Tyriar self-assigned this Jan 9, 2025
@Tyriar
Copy link
Member Author

Tyriar commented Jan 9, 2025

FYI @jerch, your work in action 🎉. Looks pretty good without any special debouncing.

@Tyriar
Copy link
Member Author

Tyriar commented Jan 9, 2025

Need to pull in xtermjs/xterm.js#5291 when it's released

@Tyriar Tyriar marked this pull request as ready for review January 9, 2025 14:27
lszomoru
lszomoru previously approved these changes Jan 9, 2025
View reviewed changes
@jerch
Copy link

jerch commented Jan 9, 2025

Nice 😍

@Tyriar Tyriar merged commit 0e20692 into main Jan 10, 2025
8 checks passed
@Tyriar Tyriar deleted the tyriar/237564_progress_handler branch January 10, 2025 13:52
@Gnium-NFT Gnium-NFT mentioned this pull request Jan 10, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@songjianet songjianet songjianet approved these changes

@lszomoru lszomoru lszomoru approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
January 2025
Development

Successfully merging this pull request may close these issues.

Implement terminal sequence progress handler
4 participants
@Tyriar @jerch @lszomoru @songjianet