Undo/redo, bulk edit and onWill-file events #110930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible that additional workspace edits from an
onWill[Create|Rename|Delete]Files
are added to the same undo/redo groups as the initiating operation. The sample is the Java file rename which makes a text edit before the actual rename. Those should only require a single undo.This is PR is kinda large but simple. It spreads data because
onWill
-events are triggered from the working copy serviceonWill
-event listenerfyi - the alternative would have been to move all
onWill
-event logic into the bulk edit service but since there are still direct consumer of the working copy service it would have meant that the API now fires less event, like for "save as".Somewhat open questions
onWill
-events will not fire anymore when undoing/redoing. That's to safe the undo-stack but might be unexpected?onDid
-events that are caused by undoing/redoing? Those cannot piggy-bag extra edits tho.