Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate debug type 'node2' #20993

Closed
weinand opened this issue Feb 21, 2017 · 2 comments
Closed

Deprecate debug type 'node2' #20993

weinand opened this issue Feb 21, 2017 · 2 comments
Assignees
@roblourens @isidorn
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
February 2017

Comments

@weinand
Copy link
Contributor

weinand commented Feb 21, 2017 •
edited
Loading

In order to smoothen the node debugging experience (see #19650) we should try to deprecate the debug type 'node2' and make it as invisible as possible.

If we cannot deprecate the debug type, we should warn the user when launching a 'node2' debug session (which could be done in the node-debug2 extension code).
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Feb 21, 2017
@isidorn
Copy link
Contributor

isidorn commented Feb 21, 2017

Feedback on the message welcome

screen shot 2017-02-21 at 17 21 14

@isidorn isidorn added the verification-needed Verification of issue is requested label Feb 21, 2017
@isidorn isidorn added this to the February 2017 milestone Feb 21, 2017
weinand added a commit that referenced this issue Feb 21, 2017
@weinand
add protocol attribute to deprecation message; fixes #20993
ad82ccd
@weinand
Copy link
Contributor Author

weinand commented Feb 21, 2017

I've added a blurb about the 'protocol' to the deprecation message:

2017-02-21_17-40-12

@jrieken jrieken added the verified Verification succeeded label Feb 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@isidorn isidorn

Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
February 2017
Development

No branches or pull requests
4 participants
@roblourens @jrieken @weinand @isidorn