Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: fullscreen window shows titlebar when command center is enabled #158359

Closed
bpasero opened this issue Aug 17, 2022 · 1 comment · Fixed by #162432
Closed

Windows: fullscreen window shows titlebar when command center is enabled #158359

bpasero opened this issue Aug 17, 2022 · 1 comment · Fixed by #162432
Assignees
@jrieken @sbatten
Labels
command-center insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues verified Verification succeeded workbench-window Window management
Milestone
September 2022

Comments

@bpasero
Copy link
Member

bpasero commented Aug 17, 2022

Typically when I make a window fullscreen, I would not expect to see the title bar, but on Windows when command center is enabled, the custom title bar shows up in fullscreen mode. It does for example not on macOS.
@vscodenpa vscodenpa mentioned this issue Aug 17, 2022
Closed
@jrieken jrieken added the titlebar VS Code main title bar issues label Aug 17, 2022
@gjsjohnmurray
Copy link
Contributor

Related to #154650

@jrieken jrieken mentioned this issue Sep 30, 2022
Merged
jrieken added a commit that referenced this issue Sep 30, 2022
@jrieken
CC enablement doesn't influence custom titlebar enablement
b415c5c 
mitigates #161948
undoes #151892
(likely) fixes #158359
jrieken added a commit that referenced this issue Sep 30, 2022
@jrieken
CC enablement doesn't influence custom titlebar enablement (#162432)
20e2a15 
mitigates #161948
undoes #151892
(likely) fixes #158359
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Sep 30, 2022
@bpasero bpasero added this to the September 2022 milestone Sep 30, 2022
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 3, 2022
@sbatten sbatten added the verified Verification succeeded label Oct 4, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

@sbatten sbatten

Labels
command-center insiders-released Patch has been released in VS Code Insiders titlebar VS Code main title bar issues verified Verification succeeded workbench-window Window management
Projects
None yet
Milestone
September 2022
Development

Successfully merging a pull request may close this issue.

CC enablement doesn't influence custom titlebar enablement microsoft/vscode
5 participants
@bpasero @jrieken @sbatten @gjsjohnmurray @vscodenpa