Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to call debug adapter API from extension #15656

Closed
weinand opened this issue Nov 17, 2016 · 7 comments
Closed

Support to call debug adapter API from extension #15656

weinand opened this issue Nov 17, 2016 · 7 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Nov 17, 2016

No description provided.

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 17, 2016
@weinand weinand added the feature-request Request for new features or functionality label Nov 17, 2016
@isidorn
Copy link
Contributor

isidorn commented Nov 17, 2016

Assigning to november to investigate

@roblourens
Copy link
Member

roblourens commented Jan 3, 2017

What's your current thinking about how the extension/debug adapter communication should work for skipFiles?

@weinand
Copy link
Contributor Author

weinand commented Jan 4, 2017

@roblourens since the skip-files-ui-feature is a one-off private feature, you are free to introduce whatever protocol you need. Only your debug adapter will use it.

@weinand weinand added this to the January 2017 milestone Jan 12, 2017
isidorn added a commit that referenced this issue Jan 12, 2017
@isidorn
Copy link
Contributor

isidorn commented Jan 12, 2017

We have added a first version for this. After discussing with @weinand we have decided that the first step for allowing this is for the extension to simply pass the request to vscode which would forward it to the debug adapter.
In the future we should consider making this official API in vscode.d.ts, currently it is simply a workbench command.

Each extension can exectue the command "workbench.customDebugRequest" and pass the request and arguments. Here's an example:

vscode.commands.executeCommand('workbench.customDebugRequest', 'myRequest', { test: 5 });

Closing this issue as there is a seperate issue #14728 for tracking the implementation in skip files.
@roblourens let me know if you need anything else on the vscode side or ping if you have any feedback on how we exposed this

@isidorn isidorn closed this as completed Jan 12, 2017
@roblourens
Copy link
Member

Looks like exactly what I need, I'll try it out.

@weinand
Copy link
Contributor Author

weinand commented Jun 1, 2017

@DanTup please see https://github.com/Microsoft/vscode-node-debug/blob/master/src/node/extension.ts#L42 for sending a request from the extension to the DA, and https://github.com/Microsoft/vscode-node-debug/blob/master/src/node/nodeDebug.ts#L3716 for how to handle the request in the DA.

We are working on improving this API...

@DanTup
Copy link
Contributor

DanTup commented Jun 2, 2017

@weinand Thanks! I managed to find that (and this issue) after commenting last night; looks like it should do exactly what I need, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants