-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to call debug adapter API from extension #15656
Comments
Assigning to november to investigate |
What's your current thinking about how the extension/debug adapter communication should work for skipFiles? |
@roblourens since the skip-files-ui-feature is a one-off private feature, you are free to introduce whatever protocol you need. Only your debug adapter will use it. |
We have added a first version for this. After discussing with @weinand we have decided that the first step for allowing this is for the extension to simply pass the request to vscode which would forward it to the debug adapter. Each extension can exectue the command vscode.commands.executeCommand('workbench.customDebugRequest', 'myRequest', { test: 5 }); Closing this issue as there is a seperate issue #14728 for tracking the implementation in skip files. |
Looks like exactly what I need, I'll try it out. |
@DanTup please see https://github.com/Microsoft/vscode-node-debug/blob/master/src/node/extension.ts#L42 for sending a request from the extension to the DA, and https://github.com/Microsoft/vscode-node-debug/blob/master/src/node/nodeDebug.ts#L3716 for how to handle the request in the DA. We are working on improving this API... |
@weinand Thanks! I managed to find that (and this issue) after commenting last night; looks like it should do exactly what I need, thanks! |
No description provided.
The text was updated successfully, but these errors were encountered: