Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect shells that fail to launch when shell integration injection fails #151934

Closed
Tyriar opened this issue Jun 13, 2022 · 4 comments · Fixed by #152266
Closed

Detect shells that fail to launch when shell integration injection fails #151934

Tyriar opened this issue Jun 13, 2022 · 4 comments · Fixed by #152266
Assignees
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration infrastructure, command decorations, etc.
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 13, 2022

If a shell fails to launch when shell integration injection fails we should allow the user to recover without needing to investigate. Some options:

  • Automatically launch a non-injected shell, this could disable terminal.integrated.shellIntegration.enabled but we should be very careful if so, a notification would be better
  • Prompt to launch a non-injected shell?
@Tyriar Tyriar added feature-request Request for new features or functionality terminal-shell-integration Shell integration infrastructure, command decorations, etc. labels Jun 13, 2022
@Tyriar Tyriar added this to the June 2022 milestone Jun 13, 2022
@meganrogge
Copy link
Contributor

we could even launch the terminal for them with it disabled? that would minimize the impact to the user

@Tyriar
Copy link
Member Author

Tyriar commented Jun 13, 2022

Something we don't want to do: Disable without some sort of user prompt because if we shipped a bad update for example all users would have the feature disabled forever unless they noticed.

@meganrogge
Copy link
Contributor

Maybe the best of both worlds would be to launch a terminal without shell integration while keeping it enabled and inform the user with a notification abt ways to troubleshoot for future launches?

@meganrogge
Copy link
Contributor

We're thinking to prevent workflow interruption to:

  • create a new terminal that doesn't have shell integration enabled
  • show an indicator on the terminal tab that contains info about this on hover
  • status bar hover action

meganrogge added a commit that referenced this issue Jun 15, 2022
@Tyriar Tyriar removed their assignment Jun 17, 2022
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders on-testplan terminal-shell-integration Shell integration infrastructure, command decorations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants