Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Placeholder decoration overlaid with success/error decoration #144597

Closed
joyceerhl opened this issue Mar 7, 2022 · 9 comments · Fixed by #144600
Closed

Placeholder decoration overlaid with success/error decoration #144597

joyceerhl opened this issue Mar 7, 2022 · 9 comments · Fixed by #144600
Assignees
@Tyriar @meganrogge
Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration windows VS Code on Windows issues
Milestone
Backlog

Comments

@joyceerhl
Copy link
Collaborator

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.66-insider
  • OS Version: Windows 11

Steps to Reproduce:

  1. Enable shell integration
  2. Run a successful command
  3. 🐛 see that success/error decorations are rendered on top of placeholder decorations
    image
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. confirmed Issue has been confirmed by VS Code Team member labels Mar 7, 2022
@meganrogge meganrogge added this to the March 2022 milestone Mar 7, 2022
meganrogge added a commit that referenced this issue Mar 7, 2022
@meganrogge
fix #144597
e99598a
meganrogge added a commit that referenced this issue Mar 7, 2022
@meganrogge
fix #144597
85c1e3e
@meganrogge meganrogge mentioned this issue Mar 7, 2022
Merged
@joyceerhl joyceerhl mentioned this issue Mar 25, 2022
Closed
@joyceerhl joyceerhl added the verification-found Issue verification failed label Mar 25, 2022
@joyceerhl joyceerhl reopened this Mar 25, 2022
@joyceerhl
Copy link
Collaborator Author

Still seeing this. In addition, when I click on the overlaid command decorations, the entire VS Code UI locks up for about 3-5 seconds before the decoration menu appears:
Recording 2022-03-24 at 19 51 02

@meganrogge meganrogge changed the title Placeholder decoration overlaid with success/error decoration f Mar 25, 2022
@meganrogge meganrogge changed the title f Placeholder decoration overlaid with success/error decoration Mar 25, 2022
@meganrogge
Copy link
Contributor

I can't reproduce this
Screen Shot 2022-03-25 at 9 01 17 AM

@Tyriar
Copy link
Member

Tyriar commented Mar 25, 2022

@joyceerhl how did you get the error icon to overlap the other icon on the first line? I'm guessing this is a Windows only problem.

@Tyriar Tyriar modified the milestones: March 2022, April 2022 Mar 25, 2022
@Tyriar Tyriar removed verification-found Issue verification failed confirmed Issue has been confirmed by VS Code Team member labels Mar 25, 2022
@joyceerhl
Copy link
Collaborator Author

I think I had to run the Terminal: Clear command a couple times. I'll report back if I nail down a better repro.

@joyceerhl
Copy link
Collaborator Author

OK, repro steps (this is reproducible 100% of the time for me):

  1. Run a command
  2. Run Terminal: Clear
  3. Run another command
  4. Run Terminal: Clear again
  5. 🐛 decorations overlaid
overlay.mp4

@meganrogge
Copy link
Contributor

on Mac cannot repro - possibly because of this bug

clear.mov

@Tyriar
Copy link
Member

Tyriar commented Mar 28, 2022

Think this is a Windows problem

@Tyriar Tyriar added the windows VS Code on Windows issues label Mar 28, 2022
@Tyriar Tyriar mentioned this issue Mar 31, 2022
Closed
@meganrogge meganrogge modified the milestones: April 2022, May 2022 Apr 25, 2022
@meganrogge meganrogge removed their assignment May 2, 2022
@meganrogge meganrogge assigned meganrogge and Tyriar and unassigned Tyriar and meganrogge May 25, 2022
@Tyriar
Copy link
Member

Tyriar commented May 27, 2022

Deferring this as it's pretty low impact

@Tyriar Tyriar modified the milestones: May 2022, Backlog May 27, 2022
@Tyriar Tyriar mentioned this issue Jun 3, 2022
Closed
@meganrogge meganrogge mentioned this issue Jun 3, 2022
Closed
@meganrogge meganrogge removed the windows VS Code on Windows issues label Jun 3, 2022
@Tyriar Tyriar added terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration windows VS Code on Windows issues labels Jun 3, 2022
@Tyriar Tyriar mentioned this issue Jun 13, 2022
Closed
7 tasks
@meganrogge
Copy link
Contributor

can't reproduce anymore

@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

@meganrogge meganrogge

Labels
bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration infrastructure, command decorations, etc. terminal-shell-pwsh An issue in the terminal specific to PowerShell, including shell integration windows VS Code on Windows issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix overlapping decoration microsoft/vscode
4 participants
@Tyriar @meganrogge @joyceerhl and others