Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to expand find menu in notebook editor #141516

Closed
devinvalenciano opened this issue Jan 26, 2022 · 1 comment · Fixed by #154550
Closed

Unable to expand find menu in notebook editor #141516

devinvalenciano opened this issue Jan 26, 2022 · 1 comment · Fixed by #154550
Assignees
@rebornix @andreamah
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-find verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2022

Comments

@devinvalenciano
Copy link
Contributor

Version: 1.64.0-insider (user setup)
Commit: f93c696
Date: 2022-01-25T08:42:41.055Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22000

Testing #141346

Steps to Reproduce:

  1. Open notebook editor
  2. Open find menu
  3. Try to expand the size of the find menu - on my device, I'm unable to. Also, if you look closely, there's a little grey line on the left side of the find menu on Stable that indicates you can drag - I don't see an equivalent on the find menu in the notebook editor.

Recording 2022-01-25 at 18 23 40
Clip shows Stable first (grey theme), then Insiders (blue theme)
@rebornix rebornix added feature-request Request for new features or functionality notebook-find labels Jan 26, 2022
@rebornix rebornix added this to the Backlog milestone Jan 26, 2022
@rebornix rebornix mentioned this issue Jan 26, 2022
Closed
@gjsjohnmurray gjsjohnmurray mentioned this issue Feb 10, 2022
Closed
@kieferrm kieferrm mentioned this issue Mar 14, 2022
Closed
87 tasks
@kieferrm kieferrm mentioned this issue Apr 3, 2022
Closed
@kieferrm kieferrm mentioned this issue Apr 26, 2022
Closed
15 tasks
@kieferrm kieferrm mentioned this issue May 7, 2022
Closed
99 tasks
@kieferrm kieferrm mentioned this issue Jun 11, 2022
Closed
99 tasks
@andreamah andreamah self-assigned this Jul 8, 2022
@andreamah andreamah mentioned this issue Jul 8, 2022
Merged
@roblourens
Copy link
Member

roblourens commented Jul 8, 2022 •
edited
Loading

@andreamah - didn't realize you had a PR already! I think that is a good start. Don't worry about just copying code from the editor's FindWidget, I think there may be some subtle differences and it's not complex enough to reuse an implementation. If you get stuck here when I'm out, @rebornix can help

@kieferrm kieferrm mentioned this issue Jul 9, 2022
Closed
98 tasks
andreamah added a commit that referenced this issue Jul 13, 2022
@andreamah
Unable to expand find menu in notebook editor
d275e7b 
Fixes #141516
@andreamah andreamah modified the milestones: Backlog, July 2022 Jul 13, 2022
andreamah added a commit that referenced this issue Jul 15, 2022
@andreamah
Flexible-width Find Menu in Notebook (#154550)
425aaeb 
Fixes #141516
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 15, 2022
jrieken pushed a commit that referenced this issue Jul 18, 2022
@andreamah @jrieken
Flexible-width Find Menu in Notebook (#154550)
c744458 
Fixes #141516
@andreamah andreamah added the verification-needed Verification of issue is requested label Jul 25, 2022
@lramos15 lramos15 added the verified Verification succeeded label Jul 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

@andreamah andreamah

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders notebook-find verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2022
Development

Successfully merging a pull request may close this issue.

Flexible-width Find Menu in Notebook microsoft/vscode
7 participants
@roblourens @rebornix @devinvalenciano @lramos15 @andreamah @vscodenpa and others